made better type annotations

This commit is contained in:
Karma Riuk
2025-03-17 19:58:28 +01:00
parent 119c6399d8
commit 5aa7054ea2

View File

@ -1,7 +1,7 @@
from abc import ABC, abstractmethod from abc import ABC, abstractmethod
import os, re, docker, signal, sys import os, re, docker, signal, sys
from bs4 import BeautifulSoup from bs4 import BeautifulSoup
from typing import Generator, Optional from typing import Iterable, Optional
import xml.etree.ElementTree as ET import xml.etree.ElementTree as ET
@ -148,7 +148,7 @@ class BuildHandler(ABC):
pass pass
@abstractmethod @abstractmethod
def get_jacoco_report_paths(self) -> Generator[str]: def get_jacoco_report_paths(self) -> Iterable[str]:
pass pass
@abstractmethod @abstractmethod
@ -203,7 +203,7 @@ class MavenHandler(BuildHandler):
self.updates["n_tests_skipped"] += skipped self.updates["n_tests_skipped"] += skipped
self.updates["n_tests_passed"] += (tests_run - (failures + errors)) # Calculate passed tests self.updates["n_tests_passed"] += (tests_run - (failures + errors)) # Calculate passed tests
def get_jacoco_report_paths(self) -> Generator[str]: def get_jacoco_report_paths(self) -> Iterable[str]:
yield os.path.join(self.path, "target/site/jacoco-aggregate/jacoco.xml") yield os.path.join(self.path, "target/site/jacoco-aggregate/jacoco.xml")
class GradleHandler(BuildHandler): class GradleHandler(BuildHandler):
@ -271,7 +271,7 @@ class GradleHandler(BuildHandler):
# Calculate passed tests # Calculate passed tests
self.updates["n_tests_passed"] = self.updates["n_tests"] - self.updates["n_tests_failed"] self.updates["n_tests_passed"] = self.updates["n_tests"] - self.updates["n_tests_failed"]
def get_jacoco_report_paths(self) -> Generator[str]: def get_jacoco_report_paths(self) -> Iterable[str]:
raise GradleAggregateReportNotFound("Gradle does not generate a single coverage report file") raise GradleAggregateReportNotFound("Gradle does not generate a single coverage report file")
class NoTestsFoundError(Exception): class NoTestsFoundError(Exception):