From 5aa7054ea271069905975a6e5bf3a261aadb4f7c Mon Sep 17 00:00:00 2001 From: Karma Riuk Date: Mon, 17 Mar 2025 19:58:28 +0100 Subject: [PATCH] made better type annotations --- handlers.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/handlers.py b/handlers.py index 9c0c3e5..198de32 100644 --- a/handlers.py +++ b/handlers.py @@ -1,7 +1,7 @@ from abc import ABC, abstractmethod import os, re, docker, signal, sys from bs4 import BeautifulSoup -from typing import Generator, Optional +from typing import Iterable, Optional import xml.etree.ElementTree as ET @@ -148,7 +148,7 @@ class BuildHandler(ABC): pass @abstractmethod - def get_jacoco_report_paths(self) -> Generator[str]: + def get_jacoco_report_paths(self) -> Iterable[str]: pass @abstractmethod @@ -203,7 +203,7 @@ class MavenHandler(BuildHandler): self.updates["n_tests_skipped"] += skipped self.updates["n_tests_passed"] += (tests_run - (failures + errors)) # Calculate passed tests - def get_jacoco_report_paths(self) -> Generator[str]: + def get_jacoco_report_paths(self) -> Iterable[str]: yield os.path.join(self.path, "target/site/jacoco-aggregate/jacoco.xml") class GradleHandler(BuildHandler): @@ -271,7 +271,7 @@ class GradleHandler(BuildHandler): # Calculate passed tests self.updates["n_tests_passed"] = self.updates["n_tests"] - self.updates["n_tests_failed"] - def get_jacoco_report_paths(self) -> Generator[str]: + def get_jacoco_report_paths(self) -> Iterable[str]: raise GradleAggregateReportNotFound("Gradle does not generate a single coverage report file") class NoTestsFoundError(Exception):