karma/crab
1
0
Fork 0
mirror of https://github.com/karma-riuk/crab.git synced 2025-07-05 05:28:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed how we get the diffs before (it was wrong),

Browse Source 
extracted the way to get the last commit before the comments
This commit is contained in:
Karma Riuk
2025-04-01 09:52:57 +02:00
parent af4fbaa7f3
commit f7d70eed6c
1 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
pull_requests.py
View File

@ -79,20 +79,7 @@ def reset_repo_to_latest_commit(repo_path: str) -> None:
run_git_cmd(["reset", "--hard", current_branch], repo_path)
def get_diffs_before(repo: Repository, pr: PullRequest) -> dict[str, str]:
comments = list(pr.get_review_comments())
comments.sort(key=lambda comment: comment.created_at)
first_comment = comments[0]
try:
return {
file.filename: file.patch
for file in repo.compare(pr.base.sha, first_comment.commit_id).files
}
except GithubException as e:
raise NoDiffsBeforeError(e)
def get_diffs_after(repo: Repository, pr: PullRequest) -> dict[str, str]:
def get_last_commit_before_comments(pr: PullRequest) -> Commit:
comments = list(pr.get_review_comments())
commits = list(pr.get_commits())
comments.sort(key=lambda comment: comment.created_at)
@ -103,7 +90,22 @@ def get_diffs_after(repo: Repository, pr: PullRequest) -> dict[str, str]:
for commit in commits[:]:
if commit.commit.author.date > first_comment.created_at:
commits.remove(commit)
last_commit_before_comments = commits[-1]
return commits[-1]
def get_diffs_before(repo: Repository, pr: PullRequest) -> dict[str, str]:
last_commit_before_comments = get_last_commit_before_comments(pr)
try:
return {
file.filename: file.patch
for file in repo.compare(pr.base.sha, last_commit_before_comments.sha).files
}
except GithubException as e:
raise NoDiffsBeforeError(e)
def get_diffs_after(repo: Repository, pr: PullRequest) -> dict[str, str]:
last_commit_before_comments = get_last_commit_before_comments(pr)
try:
return {
file.filename: file.patch