From ae516b6c3401fab0e15212d4299ffc03b9ab7ddf Mon Sep 17 00:00:00 2001
From: Karma Riuk <riukkarma@gmail.com>
Date: Wed, 14 May 2025 09:17:16 +0200
Subject: [PATCH] removed good and put is_code_related in selection instead

---
 dataset.py          |  3 ++-
 manual_selection.py | 15 +++++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/dataset.py b/dataset.py
index f8778a6..9e9d8e8 100644
--- a/dataset.py
+++ b/dataset.py
@@ -23,7 +23,8 @@ class Comment:
 class Selection:
     comment_suggests_change: bool
     diff_after_address_change: Optional[bool]
-    good: Optional[bool]
+    is_code_related: bool
+
 
 @dataclass
 class Metadata:
diff --git a/manual_selection.py b/manual_selection.py
index 28c424f..54762cf 100644
--- a/manual_selection.py
+++ b/manual_selection.py
@@ -122,6 +122,7 @@ def main(
             pr_url = f"https://github.com/{entry.metadata.repo}/pull/{entry.metadata.pr_number}"
             print(f"\nPull Request : {pr_url}")
 
+            is_code_related = any(file.file.endswith('.java') for file in entry.comments)
             for comment in entry.comments:
                 print("\nComment:", comment.body)
 
@@ -136,15 +137,17 @@ def main(
                     entry.metadata.selection = Selection(
                         comment_suggests_change=False,
                         diff_after_address_change=None,
-                        good=False,
+                        is_code_related=any(file.file.endswith('.java') for file in entry.comments),
                     )
                     break
 
                 if validation_mode == ValidationMode.COMMENT:
                     entry.metadata.selection = Selection(
                         comment_suggests_change=True,
-                        diff_after_address_change=None,
-                        good=True,
+                        diff_after_address_change=sel.diff_after_address_change
+                        if sel is not None
+                        else None,
+                        is_code_related=is_code_related,
                     )
                     n_good += 1
                     break
@@ -169,7 +172,7 @@ def main(
                     entry.metadata.selection = Selection(
                         comment_suggests_change=True,
                         diff_after_address_change=False,
-                        good=False,
+                        is_code_related=is_code_related,
                     )
                     break
 
@@ -208,7 +211,7 @@ def main(
                         entry.metadata.selection = Selection(
                             comment_suggests_change=True,
                             diff_after_address_change=False,
-                            good=False,
+                            is_code_related=is_code_related,
                         )
                         break
 
@@ -223,7 +226,7 @@ def main(
                 entry.metadata.selection = Selection(
                     comment_suggests_change=True,
                     diff_after_address_change=True,
-                    good=True,
+                    is_code_related=is_code_related,
                 )
                 if len(relevant_diffs) > 0:
                     n_good += 1