karma/crab
1
0
Fork 0
mirror of https://github.com/karma-riuk/crab.git synced 2025-07-05 13:38:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

since i know have access to the file pointed by

Browse Source 
the comment, I just check that one for tests
This commit is contained in:
Karma Riuk
2025-03-20 10:13:48 +01:00
parent 8081b4ff76
commit 4b83a822a1
1 changed files with 5 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
pull_requests.py
View File

@ -86,11 +86,13 @@ def process_pull(repo: Repository, pr: PullRequest, dataset: Dataset, repos_dir:
comments = list(pr.get_review_comments()) comments = list(pr.get_review_comments())
assert len(comments) == 1 assert len(comments) == 1
comment_text = comments[0].body if comments else "" comment = comments[0]
comment_text = comment.body
commented_file_path = comment.path
diffs_after = {file.filename: file.patch for file in repo.compare(first_commit.sha, last_commit.sha).files} diffs_after = {file.filename: file.patch for file in repo.compare(first_commit.sha, last_commit.sha).files}
entry = DatasetEntry( entry = DatasetEntry(
metadata=Metadata(repo.full_name, pr.number, pr.merge_commit_sha), metadata=Metadata(repo.full_name, pr.number, pr.merge_commit_sha, commented_file_path),
files={file.filename: FileData(file.filename) for file in pr.get_files()}, files={file.filename: FileData(file.filename) for file in pr.get_files()},
diffs_before=diffs_before, diffs_before=diffs_before,
comment=comment_text, comment=comment_text,
@ -141,34 +143,12 @@ def process_pull(repo: Repository, pr: PullRequest, dataset: Dataset, repos_dir:
entry.metadata.build_system = build_handler.get_type() entry.metadata.build_system = build_handler.get_type()
build_handler.set_client(docker_client) build_handler.set_client(docker_client)
def _check_coverage(filenames: list[str]):
should_throw = True
error = None
for filename in filenames:
try:
# first run the coverage over all the files, and then throw if
# it's necessary I wouldn't want to throw away this entry if
# one of the files inside the PR is a README (which is by
# default not covered by any tests). I want to consider it
# successful if at least one of the files is covered. Then I
# want to exclude manually if it isn't good
entry.files[filename].coverage = build_handler.check_coverage(filename)
# if we didn't throw, it means that the file was covered
should_throw = False
except FileNotCovered as e:
error = e
if should_throw and error is not None:
raise error
steps = [ steps = [
("Checking for tests...", build_handler.check_for_tests), ("Checking for tests...", build_handler.check_for_tests),
("Compiling...", build_handler.compile_repo), ("Compiling...", build_handler.compile_repo),
("Running tests...", build_handler.test_repo), ("Running tests...", build_handler.test_repo),
("Generating coverage...", build_handler.generate_coverage_report), ("Generating coverage...", build_handler.generate_coverage_report),
("Checking coverage...", lambda: _check_coverage([file.filename for file in pr.get_files()])), ("Checking coverage...", lambda: build_handler.check_coverage(commented_file_path)),
] ]
with build_handler, tqdm(total=len(steps), desc="Processing PR", leave=False) as pbar: with build_handler, tqdm(total=len(steps), desc="Processing PR", leave=False) as pbar: