karma/crab
1
0
Fork 0
mirror of https://github.com/karma-riuk/crab.git synced 2025-07-05 05:28:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

some users have been deleted since, so the user

Browse Source 
attribute of the comment is None
This commit is contained in:
Karma Riuk
2025-04-01 09:19:52 +02:00
parent 306e80648b
commit 28eebf158a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pull_requests.py
View File

@ -55,11 +55,13 @@ def is_pull_good(pull: PullRequest, verbose: bool = False) -> bool:
if comments.totalCount == 2: if comments.totalCount == 2:
comment_1, comment_2 = sorted(comments, key=lambda c: c.created_at) comment_1, comment_2 = sorted(comments, key=lambda c: c.created_at)
if comment_2.user is not None:
return False # we can't if the second is from the author, so we discard the PR
is_reply = comment_2.in_reply_to_id == comment_1.id if comment_1.user is not None and not (
is_from_author = comment_2.user.id == pull.user.id comment_2.in_reply_to_id == comment_1.id # is reply
and comment_2.user.id == pull.user.id # from the author of the PR
if not (is_reply and is_from_author): ):
return False return False
return has_only_1_comment(pull.get_commits(), pull.get_review_comments(), verbose=verbose) return has_only_1_comment(pull.get_commits(), pull.get_review_comments(), verbose=verbose)